Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module for Azure eventhub namespace #55274

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@MyronFanQiu
Copy link
Contributor

MyronFanQiu commented Apr 15, 2019

SUMMARY
  • azure_rm_eventhubnamespace: create, update and delete an Azure eventhub namespace.
  • azure_rm_eventhubnamespace_facts: gather facts for an a specific eventhub namespace or all eventhub namespaces. Include showing sas policies.
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • azure_rm_eventhubnamespace
ADDITIONAL INFORMATION
2.9

@MyronFanQiu MyronFanQiu force-pushed the VSChina:eventhub-namespace branch from 347b2ef to b8902cd Apr 15, 2019

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 15, 2019

@MyronFanQiu this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 15, 2019

@MyronFanQiu, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor Author

MyronFanQiu commented Apr 15, 2019

@zikalino @yuwzho @yungezz Would you please review the PR when you are free? Thank you very much!

MyronFanQiu added some commits Apr 15, 2019

support eventhub namespace creation
support gathering facts for eventhub namespace

@MyronFanQiu MyronFanQiu force-pushed the VSChina:eventhub-namespace branch from a2086ff to 715c7bd Apr 15, 2019


self.results = dict(
changed=False,
id=dict()

This comment has been minimized.

Copy link
@yungezz

yungezz Apr 15, 2019

Contributor

id is str


def check_status(self, changed, eventhubnamespace):
# Compare sku
if self.sku and self.sku != eventhubnamespace.sku.name:

This comment has been minimized.

Copy link
@yungezz

yungezz Apr 15, 2019

Contributor

default value of sku is error-prone. suppose first time user set sku as premium or something, second time not setting sku, so default is basic, premium!=basic, but actually user don't want to change this field.

This comment has been minimized.

Copy link
@MyronFanQiu

MyronFanQiu Apr 15, 2019

Author Contributor

I checked the code. During each update process, if the sku is not set, the current sku will be wrote back explicitly. I deleted the confusing part of the documentation. Thanks!

@ansibot ansibot removed the needs_triage label Apr 15, 2019

@MyronFanQiu MyronFanQiu force-pushed the VSChina:eventhub-namespace branch from 824d354 to cac9ac4 Apr 15, 2019

delete the confusing part of documentation about SKU
add tags in the integration test

@MyronFanQiu MyronFanQiu force-pushed the VSChina:eventhub-namespace branch from cac9ac4 to 721c7be Apr 15, 2019

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor Author

MyronFanQiu commented Apr 16, 2019

@zikalino Hi zim~ Could you help me review the PR when you have time? Thank you very much!

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor Author

MyronFanQiu commented Apr 16, 2019

@yuwzho Hi yuwei~ Could you help me review the PR? Thank you very much! 😄

@MyronFanQiu MyronFanQiu changed the title [WIP] add new module for azure Eventhub add new module for azure Eventhub Apr 18, 2019

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor Author

MyronFanQiu commented Apr 18, 2019

ready_for_review

@ansibot ansibot added needs_revision and removed WIP labels Apr 18, 2019

@MyronFanQiu MyronFanQiu changed the title add new module for azure Eventhub add new module for Azure Eventhub namespace Apr 18, 2019

@MyronFanQiu MyronFanQiu changed the title add new module for Azure Eventhub namespace New module for Azure eventhub namespace Apr 18, 2019

@yuwzho

yuwzho approved these changes Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.