Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsphere_guest: corrected fix #19716 misbehaviour #55285

Merged

Conversation

Projects
None yet
4 participants
@rosowiecki
Copy link
Contributor

commented Apr 15, 2019

SUMMARY

Fix #19716 introduced buggy behaviour to obsolete vsphere_guest module:
A) when creating machine without optional vm_extra_config it returned "vm not present" and OK status instead of creating machine or failing
B) when performing power_on/off operations on absent machine, it didn't fail.

With this patch:
A) machine is created (vm_extra_config is not necessary)
B) operation fails

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vsphere_guest

ADDITIONAL INFORMATION

Obsolete vsphere_guest module works for old ESXi installation, while vmware_guest refuses because of licensing reasons. That's why I'm motivated to still support it in stable branches (backport to stable-2.7 will follow, if this request is accepted). Standard pull request to devel branch is not possible anymore because of a1c8fc3.


vsphere_guest: corrected fix #19716 misbehaviour
* creating machines without vm_extra_config is possible
* power state operation on absent machines will fail
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@rosowiecki, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@abadger

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@Akasurde since this is a change which doesn't need a counterpart in devel, could you review this and give it a +1 if the code looks good?

@rosowiecki This will also need a changelog fragment before merging. https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs-how-to

@ansibot ansibot removed the needs_triage label Apr 16, 2019

@ansibot ansibot removed the small_patch label Apr 17, 2019

@goneri goneri self-requested a review Apr 17, 2019

@goneri

goneri approved these changes Apr 17, 2019

@abadger abadger merged commit 93758a5 into ansible:stable-2.8 Apr 17, 2019

1 check passed

Shippable Run 119620 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Merged for 2.8.0rc1

rosowiecki added a commit to rosowiecki/ansible that referenced this pull request Apr 17, 2019

vsphere_guest: corrected fix ansible#19716 misbehaviour (ansible#55285)
* creating machines without vm_extra_config is possible
* power state operation on absent machines will fail

Backport from stable-2.8
(cherry picked from 93758a5)

rosowiecki added a commit to rosowiecki/ansible that referenced this pull request Apr 17, 2019

vsphere_guest: corrected fix ansible#19716 misbehaviour (ansible#55285)
* creating machines without vm_extra_config is possible
* power state operation on absent machines will fail

(cherry picked from commit 93758a5)

@rosowiecki rosowiecki deleted the rosowiecki:corrected_vsphere_guest_state_operations branch Apr 17, 2019

abadger added a commit that referenced this pull request Apr 24, 2019

vsphere_guest: corrected fix #19716 misbehaviour (#55285)
* creating machines without vm_extra_config is possible
* power state operation on absent machines will fail

(cherry picked from commit 93758a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.