Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql_user: fix regression #55292

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@bmalynovytch
Copy link
Contributor

commented Apr 15, 2019

SUMMARY

Fix regression introduced by #45355

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

mysql_user

ADDITIONAL INFORMATION

#45355 reverted a fix in regex parenthesis: https://github.com/ansible/ansible/pull/45355/files#diff-399cf46d54197b26de359e13cb8bc033R482

@bmalynovytch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@ansibot

This comment has been minimized.

@bmalynovytch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

-label needs_triage
ready_for_review

@ansibot ansibot removed the needs_triage label Apr 15, 2019

@@ -0,0 +1,2 @@
bugfixes:

This comment has been minimized.

Copy link
@gundalow

gundalow Apr 15, 2019

Contributor

Looks like the original bug only went into Ansible 2.8, so could you please remove this changelog

#45355

This comment has been minimized.

Copy link
@gundalow

gundalow Apr 15, 2019

Contributor

Otherwise we are documenting something that no one would ever have seen (in a release version of Anisble)

This comment has been minimized.

Copy link
@felixfontein

felixfontein Apr 15, 2019

Contributor

@gundalow I recently explicitly asked in #ansible-devel about changes which affect 2.8-only code and @abadger said they should also get a changelog.

Show resolved Hide resolved lib/ansible/modules/database/mysql/mysql_user.py Outdated
Update lib/ansible/modules/database/mysql/mysql_user.py
Co-Authored-By: bmalynovytch <bmalynovytch@users.noreply.github.com>

azeliashchonak added a commit to lean-delivery/ansible that referenced this pull request Apr 16, 2019

@felixfontein
Copy link
Contributor

left a comment

shipit

@ansibot ansibot added shipit and removed community_review labels Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.