Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_url: allow for asterisks in checksum. #55293

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@esuarezsantana
Copy link
Contributor

esuarezsantana commented Apr 15, 2019

SUMMARY

As commented in issue #48790, the filename in the checksum file may be prefixed with an asterisk, so it must be stripped as well. Besides, better use lstrip() instead of strip().

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

get_url

ADDITIONAL INFORMATION

Sample file: http://archive.apache.org/dist/tomcat/tomcat-7/v7.0.85/bin/apache-tomcat-7.0.85.tar.gz.sha512

get_url: allow for asterisks in checksum.
As commented in [issue #48790](#48790 (comment)), the filename in the checksum file may be prefixed with an asterisk, so it must be stripped as well. Besides, better use 'lstrip()' instead of 'strip()'.

Sample file: http://archive.apache.org/dist/tomcat/tomcat-7/v7.0.85/bin/apache-tomcat-7.0.85.tar.gz.sha512
@ansibot

This comment has been minimized.

Copy link
Contributor

ansibot commented Apr 15, 2019

@esuarezsantana

This comment has been minimized.

Copy link
Contributor Author

esuarezsantana commented Apr 15, 2019

The failed task shows:

    ...
    "msg": "Connection failure: connection was closed before a valid response was received: "
    ...

I don't see any relation with the proposed changes.

@esuarezsantana

This comment has been minimized.

Copy link
Contributor Author

esuarezsantana commented Apr 16, 2019

As read in documentation, closing and reopening to run tests again.

@esuarezsantana

This comment has been minimized.

Copy link
Contributor Author

esuarezsantana commented Apr 16, 2019

Reopening again.

@esuarezsantana

This comment has been minimized.

Copy link
Contributor Author

esuarezsantana commented Apr 17, 2019

IMHO checks are not failing because of the proposed changes.

@jillr

This comment has been minimized.

Copy link
Contributor

jillr commented Apr 18, 2019

Thanks for this, could you please write a test for this case?

@jillr jillr removed the needs_triage label Apr 18, 2019

@ansibot ansibot added core_review and removed needs_revision labels Apr 18, 2019

@esuarezsantana

This comment has been minimized.

Copy link
Contributor Author

esuarezsantana commented Apr 22, 2019

I have tried to run 'ansible-test' myself without success. So that, I have coded a test without testing it. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.