Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_url: allow for asterisks in checksum. #55293

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

@esuarezsantana
Copy link
Contributor

@esuarezsantana esuarezsantana commented Apr 15, 2019

SUMMARY

As commented in issue #48790, the filename in the checksum file may be prefixed with an asterisk, so it must be stripped as well. Besides, better use lstrip() instead of strip().

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

get_url

ADDITIONAL INFORMATION

Sample file: http://archive.apache.org/dist/tomcat/tomcat-7/v7.0.85/bin/apache-tomcat-7.0.85.tar.gz.sha512

As commented in [issue #48790](#48790 (comment)), the filename in the checksum file may be prefixed with an asterisk, so it must be stripped as well. Besides, better use 'lstrip()' instead of 'strip()'.

Sample file: http://archive.apache.org/dist/tomcat/tomcat-7/v7.0.85/bin/apache-tomcat-7.0.85.tar.gz.sha512
@ansibot
Copy link
Contributor

@ansibot ansibot commented Apr 15, 2019

@esuarezsantana
Copy link
Contributor Author

@esuarezsantana esuarezsantana commented Apr 15, 2019

The failed task shows:

    ...
    "msg": "Connection failure: connection was closed before a valid response was received: "
    ...

I don't see any relation with the proposed changes.

@esuarezsantana
Copy link
Contributor Author

@esuarezsantana esuarezsantana commented Apr 16, 2019

As read in documentation, closing and reopening to run tests again.

@esuarezsantana
Copy link
Contributor Author

@esuarezsantana esuarezsantana commented Apr 16, 2019

Reopening again.

@esuarezsantana
Copy link
Contributor Author

@esuarezsantana esuarezsantana commented Apr 17, 2019

IMHO checks are not failing because of the proposed changes.

@jillr
Copy link
Contributor

@jillr jillr commented Apr 18, 2019

Thanks for this, could you please write a test for this case?

@esuarezsantana
Copy link
Contributor Author

@esuarezsantana esuarezsantana commented Apr 22, 2019

I have tried to run 'ansible-test' myself without success. So that, I have coded a test without testing it. :-/

@paxpacis
Copy link

@paxpacis paxpacis commented Jun 25, 2019

What is the status of this issue?

I'm also running into this issue: https://archive.apache.org/dist/lucene/solr/7.7.2/solr-7.7.2.tgz.sha512

I'm running Ansible 2.8.1 with python 3.7.3

@x70b1
Copy link

@x70b1 x70b1 commented Mar 10, 2020

Any news here?

We can't manage Docker/compose without this as they have an asterisk in the sha256sum file to show that this is a binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants