Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.8] Use different headers for each HTTP method #55299

Merged
merged 2 commits into from Apr 17, 2019

Conversation

Projects
None yet
5 participants
@mariolenz
Copy link
Contributor

commented Apr 15, 2019

SUMMARY

Backport of PR #55193

Fixes #55078

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redfish_utils

ADDITIONAL INFORMATION

(cherry picked from commit f88b2cb)

@ansibot

This comment has been minimized.

@billdodd
Copy link
Contributor

left a comment

Reviewed code. Looks good.

shipit

@ansibot ansibot removed the needs_triage label Apr 15, 2019

@mariolenz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Can I

shipit

too?

@jose-delarosa

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

shipit

@ansibot ansibot added shipit and removed community_review labels Apr 16, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Code looks fine but this needs a changelog fragment before the backport is merged. https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs-how-to

@ansibot ansibot added community_review and removed shipit labels Apr 17, 2019

@mariolenz

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

Code looks fine but this needs a changelog fragment before the backport is merged. https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#changelogs-how-to

Better now?

@abadger abadger merged commit a5a5445 into ansible:stable-2.8 Apr 17, 2019

1 check passed

Shippable Run 119588 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Merged for the 2.8.0rc1 release

@mariolenz mariolenz deleted the mariolenz:backport/2.8/55193 branch Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.