Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address 2.9 uri deprecations #55330

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
3 participants
@sivel
Copy link
Member

commented Apr 15, 2019

SUMMARY

Address 2.9 uri deprecations. Fixes #55310

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
lib/ansible/modules/net_tools/basics/uri.py
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@sivel

This comment has been minimized.

Copy link
Member Author

commented Apr 15, 2019

Sanity failures will need ignored. Previously the uri module documented others in place of the args supported by the file module. This update uses extends_documentation_fragment: files instead.

@sivel sivel merged commit 07443a2 into ansible:devel Apr 16, 2019

1 check failed

Shippable Run 119311 status is FAILED.
Details

@sivel sivel removed the needs_triage label Apr 16, 2019

@mattclay

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

This change is causing CI failures in devel:

https://app.shippable.com/github/ansible/ansible/runs/119485/59/tests

TASK [rabbitmq_lookup : Post test message to the exchange (string)] ************
fatal: [testhost]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (uri) module: register Supported parameters include: attributes, backup, body, body_format, client_cert, client_key, content, creates, delimiter, dest, directory_mode, follow, follow_redirects, force, force_basic_auth, group, headers, http_agent, method, mode, owner, regexp, remote_src, removes, return_content, selevel, serole, setype, seuser, src, status_code, timeout, unix_socket, unsafe_writes, url, url_password, url_username, use_proxy, validate_certs"}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.