Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't register tests as filters #55332

Merged
merged 6 commits into from Apr 16, 2019

Conversation

Projects
None yet
5 participants
@sivel
Copy link
Member

commented Apr 15, 2019

SUMMARY

Don't register tests as filters. Fixes #55319

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
lib/ansible/template/__init__.py
ADDITIONAL INFORMATION

@ansibot ansibot added core_review and removed needs_revision labels Apr 15, 2019

@jamescassell
Copy link
Contributor

left a comment

shipit

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@ansibot ansibot added the test label Apr 16, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@ansibot ansibot added the docs label Apr 16, 2019

@@ -1,10 +0,0 @@
Sanity Tests » no-tests-as-filters

This comment has been minimized.

Copy link
@mattclay

mattclay Apr 16, 2019

Member

I'd keep this file around even though the test has been deleted. That way links from old test runs will continue to work. I've done this for several other tests which no longer exist.

This comment has been minimized.

Copy link
@sivel

sivel Apr 16, 2019

Author Member

Ok, I can do that. I'll just have to indicate it is an orphan

@ansibot ansibot removed the needs_triage label Apr 16, 2019

sivel added some commits Apr 16, 2019

@acozine

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

+1 from the docs team

@sivel sivel merged commit 9f83139 into ansible:devel Apr 16, 2019

1 check passed

Shippable Run 119460 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.