Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psrp - Fix fetch for large files #55351

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
3 participants
@jborean93
Copy link
Contributor

commented Apr 16, 2019

SUMMARY

Fixes an issue when trying to fetch a file with the psrp connection plugin. Currently it will continue to fetch the same 0 to buffer size offset and eventually cause an out of memory issue on the remote host. This fixes the offset logic so it is able to retrieve files larger than the buffer size but also fixes a memory issue caused by not manually stopping a pipeline after it is finished.

Fixes #55239

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

psrp

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

@jborean93 jborean93 merged commit 52946c4 into ansible:devel Apr 16, 2019

1 check passed

Shippable Run 119370 status is SUCCESS.
Details

@jborean93 jborean93 deleted the jborean93:psrp-fetch branch Apr 16, 2019

jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 16, 2019

psrp - Fix fetch for large files (ansible#55351)
* psrp - Fix fetch for large files

* Fix typo

(cherry picked from commit 52946c4)

jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 16, 2019

psrp - Fix fetch for large files (ansible#55351)
* psrp - Fix fetch for large files

* Fix typo

(cherry picked from commit 52946c4)
@jborean93

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Backport PRs
stable-2.7 #55406
stable-2.8 #55407

abadger added a commit that referenced this pull request Apr 16, 2019

psrp - Fix fetch for large files (#55351)
* psrp - Fix fetch for large files

* Fix typo

(cherry picked from commit 52946c4)

abadger added a commit that referenced this pull request Apr 16, 2019

psrp - Fix fetch for large files (#55351)
* psrp - Fix fetch for large files

* Fix typo

(cherry picked from commit 52946c4)

ruimoreira added a commit to ruimoreira/ansible that referenced this pull request Apr 22, 2019

psrp - Fix fetch for large files (ansible#55351)
* psrp - Fix fetch for large files

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.