Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psrp - fix test_command rc for win_reboot #55354

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
3 participants
@jborean93
Copy link
Contributor

commented Apr 16, 2019

SUMMARY

When using test_command with win_reboot over psrp, the return value was not always returned back to Ansible due to the various escaping. This caused issues as rc of 0 will have win_reboot continue when it shouldn't.

This change also unifies another command input to use a PowerShell context like raw and other command inputs. It finally simplifies the access denied errors by removing the remote shutdown privilege instead of trying to create a temp standard user and allow standard users to connect over WinRM.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_reboot

@ansibot

This comment has been minimized.

@jborean93 jborean93 merged commit 49655a4 into ansible:devel Apr 16, 2019

1 check passed

Shippable Run 119373 status is SUCCESS.
Details

@jborean93 jborean93 deleted the jborean93:test-win_reboot-psrp branch Apr 16, 2019

jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 16, 2019

jborean93 added a commit to jborean93/ansible that referenced this pull request Apr 16, 2019

@jborean93

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Backport PRs
stable-2.7 #55413
stable-2.8 #55414

abadger added a commit that referenced this pull request Apr 16, 2019

abadger added a commit that referenced this pull request Apr 16, 2019

ruimoreira added a commit to ruimoreira/ansible that referenced this pull request Apr 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.