Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new client #55368

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@zengchen1024
Copy link

commented Apr 16, 2019

SUMMARY
  1. refactor the HwcSession and split it into two classes of Config and _ServiceClient instead. Because HwcSession is a little complex and not a single function class.
  2. add two methods of 'build_path' and 'get_region'
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

hwc_network_vpc
hwc_smn_topic

ADDITIONAL INFORMATION

I have tested the changes on the real environment.

@ansibot

This comment has been minimized.

@zhongjun2

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

shipit

@zhongjun2

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

bot_status

@TommyLike

This comment has been minimized.

Copy link

commented Apr 17, 2019

shipit

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Components

lib/ansible/module_utils/hwc_utils.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_network_vpc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_smn_topic.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/plugins/doc_fragments/hwc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 3
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): zhongjun2 TommyLike zengchen1024
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@zhongjun2

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Components

lib/ansible/module_utils/hwc_utils.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_network_vpc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_smn_topic.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/plugins/doc_fragments/hwc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 3
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): zhongjun2 TommyLike zengchen1024
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@zengchen1024 zengchen1024 force-pushed the zengchen1024:use_new_client branch from 1ee5776 to c4a5485 Apr 17, 2019

@ansibot ansibot added the shipit label Apr 17, 2019

@zhongjun2

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Components

lib/ansible/module_utils/hwc_utils.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_network_vpc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_smn_topic.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/plugins/doc_fragments/hwc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): zhongjun2 zengchen1024
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@zhongjun2

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Components

lib/ansible/module_utils/hwc_utils.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_network_vpc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_smn_topic.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/plugins/doc_fragments/hwc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): zengchen1024
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@ansibot ansibot added community_review and removed shipit labels Apr 17, 2019

@zengchen1024 zengchen1024 force-pushed the zengchen1024:use_new_client branch from c4a5485 to a923dc9 Apr 17, 2019

@ansibot ansibot added the owner_pr label Apr 17, 2019

@zhongjun2

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

shipit

@zhongjun2

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Components

lib/ansible/module_utils/hwc_utils.py
support: community
maintainers: TommyLike edisonxiang freesky-edward niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_network_vpc.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

lib/ansible/modules/cloud/huawei/hwc_smn_topic.py
support: community
maintainers: TommyLike edisonxiang freesky-edward huaweicloud niuzhenguo zengchen1024 zhongjun2

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): zhongjun2 zengchen1024
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@ansibot ansibot added shipit and removed community_review labels Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.