Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local dummy repo for flatpak integration tests #55452

Open

Conversation

Projects
None yet
2 participants
@oolongbrothers
Copy link
Contributor

commented Apr 17, 2019

SUMMARY

This PR fixes the flatpak integration tests and enables them in shippable CI runs.

This is done in the same manner as #52668 did for the flatpak_remote integration tests:

Before, the tests relied on the availability of the flathub repository infrastructure. This PR replaces the use of flathub with a local dummy repository.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

flatpak

ADDITIONAL INFORMATION

I had to add a new parameter to the flatpak module: no_dependencies, which corresponds to the flatpak binary's --no_deps flag. That is because I need to install flatpaks without installing their dependency runtimes, which are by convention hosted on flathub. Without this flag that disables dependency runtime installation, I would not be able to remove the dependency on flathub. This effectively makes the installed flatpaks unusable, which is however irrelevant in the scope of these tests.

I also needed to add support for installing flatpaks from local file://-URL:s to make the dummy repo work.

I was able to remove the docker-privileged requirements without me noticing any difference in the tests' behaviour.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.