Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure_rm_keyvault_info #55497

Merged
merged 6 commits into from May 22, 2019

Conversation

Projects
None yet
4 participants
@yungezz
Copy link
Contributor

commented Apr 18, 2019

SUMMARY

add azure_rm_keyvault_info

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

yungezz added some commits Apr 18, 2019

@yungezz yungezz requested a review from zikalino Apr 18, 2019

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@yungezz, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@Madhura-CSI @brusMX @caohai @cperrin88 @devigned @gustavomcarmo @haroldwongms @iphilpot @julienstroheker @lmazuel @obsoleted @sozercan @techknowlogick @trstringer @tstringer @xscript @yaweiw @yuwzho

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@zikalino Please help review this PR when you're available! Thanks!

@ansibot ansibot added the stale_ci label May 2, 2019

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@yungezz yungezz changed the title add azure_rm_keyvault_facts add azure_rm_keyvault_info May 16, 2019

@ansibot ansibot removed the needs_triage label May 20, 2019

version_added: "2.9"
short_description: Get Azure Key Vault facts.
description:
- Get facts of Azure Key Vault.

This comment has been minimized.

Copy link
@zikalino

zikalino May 22, 2019

Contributor

I think we should have "Get info" considering renaming ;-) but that's minow

This comment has been minimized.

Copy link
@yungezz

yungezz May 22, 2019

Author Contributor

i ever think about it. but i think facts here is more common used in ansible, so keep facts.

This comment has been minimized.

Copy link
@zikalino

zikalino May 22, 2019

Contributor

it's ok, such things we can rename later anyway if we decide to

@zikalino
Copy link
Contributor

left a comment

Looks very good now. Just noticed a few really minor things, so it can be merged.

@yungezz

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

ready_for_review

@zikalino zikalino merged commit 831d3c7 into ansible:devel May 22, 2019

1 check passed

Shippable Run 123995 status is SUCCESS.
Details

@zikalino zikalino deleted the VSChina:yungez-kvfacts branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.