Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graylog roles module for interacting with the Graylog API #55522

Open
wants to merge 7 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@shortstack
Copy link

commented Apr 18, 2019

Graylog roles module for interacting with the Graylog API

SUMMARY

New module for interacting with the Graylog API, specifically creating and manipulating roles, which has been beneficial in automating Graylog functionality within CI pipelines/processes, since these have typically been manual processes.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • graylog_roles
ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@!UNKNOWN @Akint @ApsOps @D3DeFi @K-DOT @NickatEpic @RedWhiteMiko @Sedward @abulimov @akomic @andsens @brian-brazil @bwhaley @cove @dj-wasabi @dmsimard @dstoflet @eikef @ethanculler @harrisongu @hkariti @kavu @logan2211 @martinwangjian @mcodd @n0ts @nate-kingsley @nerzhul @orgito @rubentsirunyan @seuf @skornehl @smbambling @sookido @stympy @suprememoocow @t794104 @tbielawa @tsalle @woz5999

As a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add shipit if you would like to see it merged.

click here for bot help

shortstack added some commits Apr 19, 2019

@resmo
Copy link
Member

left a comment

See comments inline and let me know if I can assist further.

- Action to take against role API.
required: false
default: list
choices: [ create, update, delete, list ]

This comment has been minimized.

Copy link
@resmo

resmo Apr 22, 2019

Member

I am afraid but this is a blocker: an action option should not be necessary, because ansible should handle this by itself. This is why we usually have a state option with (at least) two options absent and present. While absent is self explaining, the present option should handle the necessary steps (create or update) to get into the state declared and return changed if action has been taken.

In any case a list state (or action) is not accepted, instead implement it in a separate module as an _info module.

Show resolved Hide resolved lib/ansible/modules/monitoring/graylog_roles.py Outdated
Show resolved Hide resolved lib/ansible/modules/monitoring/graylog_roles.py Outdated
Show resolved Hide resolved lib/ansible/modules/monitoring/graylog_roles.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.