Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle binding:vnic_type as optional #55526

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
6 participants
@dominikholler
Copy link
Contributor

commented Apr 18, 2019

SUMMARY

According to the OpenStack Networking API
the attribute binding:vnic_type of a port is optional.
This change enables the os_port module to handle
binding:vnic_type as optional.

Fixes #55524
Fixes #55525

Backport to ansible 2.8 is required.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

os_port

ADDITIONAL INFORMATION

@openstack-zuul

This comment has been minimized.

Copy link

commented Apr 18, 2019

Build succeeded (third-party-check pipeline).

@openstack-zuul

This comment has been minimized.

Copy link

commented Apr 18, 2019

Build succeeded (third-party-check pipeline).

@MaxBab

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Successfully verified the fix on my environment.

@dominikholler dominikholler force-pushed the dominikholler:vnic_type branch from f2c0ee2 to e6734f5 Apr 18, 2019

@openstack-zuul

This comment has been minimized.

Copy link

commented Apr 18, 2019

Build succeeded (third-party-check pipeline).

Handle binding:vnic_type as optional
According to the OpenStack Networking API
the attribute binding:vnic_type of a port is optional.
This change enables the os_port module to handle
binding:vnic_type as optional.

@dominikholler dominikholler force-pushed the dominikholler:vnic_type branch from e6734f5 to 07e2137 Apr 18, 2019

@openstack-zuul

This comment has been minimized.

Copy link

commented Apr 19, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added the stale_ci label Apr 27, 2019

@dominikholler

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

@gundalow can you please have a look?

@mnaser

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

shipit

@ansibot ansibot removed the needs_triage label May 5, 2019

@gtema

gtema approved these changes May 9, 2019

Copy link
Contributor

left a comment

shipit

@mnaser

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Components

changelogs/fragments/55526-optional_vnic_type.yml
support: community
maintainers:

lib/ansible/modules/cloud/openstack/os_port.py
support: community
maintainers: Shrews cloudnull dagnello emonty evrardjp gtema juliakreger mnaser odyssey4me rcarrillocruz

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): mnaser gtema
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@mwperina
Copy link
Contributor

left a comment

shipit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.