Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move idrac_redfish_* modules to dellemc/idrac directory #55536

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@jose-delarosa
Copy link
Contributor

commented Apr 18, 2019

SUMMARY

Move idrac_redfish_* modules to dellemc/idrac directory to consolidate all Dell-specific modules in one location.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

idrac_redfish_command
idrac_redfish_config
idrac_redfish_facts

ADDITIONAL INFORMATION

These modules will operate the same, no difference to functionality. Moving to a new location will consolidate all Dell-specific modules and should assign new approvers for any PRs going forward.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@jose-delarosa this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@jose-delarosa

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

Mmh, I am not adding new modules, just moving them to a new location. @rajeevarakkal, are you able to approve and merge? If not, then I'll do it one at a time, whatever it takes. Let me know.

@rajeevarakkal

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

@jose-delarosa, as a namespace maintainer I can review this module and vote for shipit. Since there is a change requested, this vote mostly will be ignored once you make next commit. Also, Core team provides the final approval and merging.

@gundalow, these modules @jose-delarosa is just moving from remote_management/redfish location toremote_management/dellemc/idrac. It will be great if you can help @jose-delarosa.

@ansibot ansibot removed the needs_triage label Apr 20, 2019

@jose-delarosa jose-delarosa referenced this pull request Apr 24, 2019

Open

idrac facts #89

@ansibot ansibot added the stale_ci label Apr 28, 2019

@jose-delarosa

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@rajeevarakkal Oh dang, this is not progressing. Did you ever ping the Core team in #ansible-devel?

@rajeevarakkal

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@jose-delarosa , yup couple of times and team give directions on what next.

Have you got a chance to justify the bot comment with core team and get this 'need revision' label removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.