Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] sysvinit: check service is started when 'reload' is used and service is stopped #55552

Conversation

@pilou-
Copy link
Contributor

@pilou- pilou- commented Apr 19, 2019

SUMMARY

sysvinit: check service is started when state: reloaded is used and service is stopped

Integration test provided.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sysvinit

ADDITIONAL INFORMATION

How to reproduce:

$ cat play.yml
- hosts: all
  gather_facts: false
  connection: docker
  tasks:
    - raw: 'DEBIAN_FRONTEND=noninteractive apt-get --assume-yes update'
    - raw: 'DEBIAN_FRONTEND=noninteractive apt-get --assume-yes install python'
    - apt:
        name: openssh-server
    - sysvinit:
        name: ssh
        state: reloaded
$ docker run --rm --name test_sysvinit -d debian:stretch sleep infinity
$ ansible-playbook -i test_sysvinit, play.yml # this command fails
$ docker stop test_sysvinit # cleanup
@pilou- pilou- force-pushed the service_reloaded_asked_restart_if_not_started branch from e8d4423 to 973cb74 Apr 19, 2019
@pilou-
Copy link
Contributor Author

@pilou- pilou- commented Apr 19, 2019

As expected, added test fails (rhel/7.6, rhel/8.0, centos6, centos7, fedora28, fedora29, opensuse15py2, opensuse15, ubuntu1604, ubuntu1804):

02:20 TASK [service : Ensure 'start' is used instead of 'reload'] ********************
02:21 fatal: [testhost]: FAILED! => {"changed": false, "msg": "Failed to reload service: ansible_test_reload", "rc": 1, "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

a proposed bugfix will be added.

as explained in the documentation
@pilou- pilou- force-pushed the service_reloaded_asked_restart_if_not_started branch from e3b020b to 864919c Apr 19, 2019
@ansibot ansibot added pre_azp and removed stale_ci labels Dec 5, 2020
@Akasurde
Copy link
Member

@Akasurde Akasurde commented Jun 8, 2021

@pilou- Are you still working on this? Thanks.

needs_info

@ansibot
Copy link
Contributor

@ansibot ansibot commented Jul 10, 2021

@pilou- This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

@ansibot
Copy link
Contributor

@ansibot ansibot commented Aug 11, 2021

@pilou- You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help

@ansibot ansibot closed this Aug 11, 2021
@ansible ansible locked and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants