Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ini_file: deprecate no_extra_spaces & add space_wrap_assignment_operator #55573

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@winem
Copy link

commented Apr 20, 2019

SUMMARY

The option no_extra_spaces is deprecate now. Added a note to the documentation. The new option space_wrap_assignment_operator should be used.

This is done to...

  • use the same name for the same option as the sysctl module does (see PR #48729)
  • avoid double negation
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ini_file

ADDITIONAL INFORMATION

@abadger - here I follow your recommendation to align the names for the option across both modules (sysctl and ini_file). #48729 (comment)
Please let me know if you miss anything - especially regarding the deprecation of no_extra_spaces. And what do you think about tests? All that comes to my mind is something like adding a setting to the foo.ini file, parse it and check for ' = ' if spaces are expected. But in context this looks a bit dirty or rather unnecessary to me.

Marcel Weinberg
ini_file: deprecate no_extra_spaces & add space_wrap_assignment_operator
This is done to...
  * use the same name for the same option as the sysctl module does (see PR #48729)
  * avoid double negation
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

Marcel Weinberg added some commits Apr 20, 2019

Marcel Weinberg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.