Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: Folder support on dynamic inventory plugin - alternative implementation #55576

Open
wants to merge 10 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@agowa338
Copy link
Contributor

commented Apr 21, 2019

SUMMARY

Include folders within the vmware inventory plugin. As the folder path is required by the gather facts plugin (future work is to make them interact seamlessly, now that we have all required information). This PR includes a commit that is also PR-ed as #55137, because it changes the vmname to its full path, which I here use to generate the inventory information and hierarchie. I'm committing this, because the PR #52782 looks stale and also does not seem to work, it does not include any folder information for my environment. Sof if that PR is going to be improved and merged, this may no longer be necessary.

Fixes #54339
Duplicates #52782

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/plugins/inventory/vmware_vm_inventory.py

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2019

@agowa338 agowa338 changed the title VMware: Folder support on dynamic inventory plugin VMware: Folder support on dynamic inventory plugin - alternative implementation Apr 21, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2019

@samdoran samdoran removed the needs_triage label Apr 23, 2019

@agowa338 agowa338 force-pushed the agowa338:patch-5 branch 4 times, most recently from 089822d to b80ae85 Apr 26, 2019

@mattclay mattclay added the ci_verified label May 2, 2019

@ansibot ansibot added the needs_rebase label May 2, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

agowa338 added some commits Apr 11, 2019

Fix TRANSFORM_INVALID_GROUP_CHARS
FIX: [DEPRECATION WARNING]: The TRANSFORM_INVALID_GROUP_CHARS settings is set to allow bad characters in group names by default, this will
change, but still be user configurable on deprecation. This feature will be removed in version 2.10. Deprecation warnings can be disabled
by setting deprecation_warnings=False in ansible.cfg.

@agowa338 agowa338 force-pushed the agowa338:patch-5 branch from b80ae85 to 2ce62c3 May 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.