Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaleway_compute: add boot_type parameter #55582

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@jackivanov
Copy link

commented Apr 22, 2019

SUMMARY

It appears that the scaleway_compute module is missing boot_type parameter

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

scaleway_compute

ADDITIONAL INFORMATION
  • boot_type: local (optional, [string]) - Boot method (local, bootscript)
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

@jackivanov jackivanov force-pushed the jackivanov:devel branch from 7ae396e to 59c73d2 Apr 22, 2019

@remyleone

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@CedricCabessa Thanks a lot
@jackivanov I think you just have to remove the default and it should be good. Maybe you should add a documentation string telling that the API automatically pick the right option if nothing is specified.

@remyleone

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

LGTM

@jackivanov jackivanov referenced this pull request Apr 27, 2019

Merged

Scaleway modules #1410

5 of 5 tasks complete

@ansibot ansibot added the stale_ci label May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.