Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixed multibyte character handling issue with py27 for tower_job_wait #55586

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@saito-hideki
Copy link
Contributor

commented Apr 22, 2019

SUMMARY
  • Fixed multibyte character handling issue for tower_job_wait module for issue #55585
  • Added multibyte hostname handling test as an integration test
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • tower_job_wait module
ADDITIONAL INFORMATION
  • The original issue is here #55585

@saito-hideki saito-hideki changed the title Fixed multibyte character handling issue for tower_job_wait [WIP] Fixed multibyte character handling issue for tower_job_wait Apr 22, 2019

@ansibot

This comment has been minimized.

@saito-hideki saito-hideki changed the title [WIP] Fixed multibyte character handling issue for tower_job_wait [WIP] Fixed multibyte character handling issue with py27 for tower_job_wait Apr 22, 2019

@saito-hideki saito-hideki changed the title [WIP] Fixed multibyte character handling issue with py27 for tower_job_wait Fixed multibyte character handling issue with py27 for tower_job_wait Apr 22, 2019

@ansibot ansibot added needs_revision and removed WIP labels Apr 22, 2019

@saito-hideki

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Re-run shippable CI

@saito-hideki saito-hideki reopened this Apr 22, 2019

@AlanCoding

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

The test failure is from

The Tower server sent back a server error. Please try again later.

This isn't a problem with either your fix or the CLI library. I don't know what's going on with the target Tower instance (but trying again later will not help).

This PR look good to me. Maybe the server bug needs to be side stepped for now somehow.

@saito-hideki

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@AlanCoding Thank you for the review! :)
Is there anything I can do to solve this CI issue ?

@AlanCoding

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

We should upgrade testing Tower server, that's the only thought I have on it right now.

@ansibot ansibot added the stale_ci label May 2, 2019

Fix multibyte character handling issue for tower_job_wait #55585
Add multibyte hostname handling test as an integration test

Signed-off-by: Hideki Saito <saito@fgrep.org>

@saito-hideki saito-hideki force-pushed the saito-hideki:pr/tower_job_wait-unicode_support branch from e7fad1d to 89d97d5 May 15, 2019

@saito-hideki saito-hideki changed the title Fixed multibyte character handling issue with py27 for tower_job_wait [WIP] Fixed multibyte character handling issue with py27 for tower_job_wait May 15, 2019

@ansibot ansibot added WIP and removed ci_verified stale_ci labels May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.