Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifying handlers by using an exact match #55624

Open
wants to merge 8 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@s-hertel
Copy link
Contributor

commented Apr 22, 2019

SUMMARY

Fixes #55575

Introduced in 2a469fd.

'string' in 'stringwithmore' is True, so make sure to wrap listeners in a list to get only exact matches: 'string' in ['stringwithmore'] is False.

ISSUE TYPE
  • Bugfix Pull Request
Fix notifying handlers by using an exact match rather than a string s…
…ubset if listen is text rather than a list

@s-hertel s-hertel changed the title Fix notifying handlers by using an exact match [WIP] Fix notifying handlers by using an exact match Apr 22, 2019

@ansibot ansibot added the WIP label Apr 22, 2019

@s-hertel s-hertel removed the needs_triage label Apr 23, 2019

@ansibot ansibot removed the small_patch label Apr 23, 2019

@s-hertel s-hertel changed the title [WIP] Fix notifying handlers by using an exact match Fix notifying handlers by using an exact match Apr 23, 2019

s-hertel added some commits Apr 24, 2019

Share code for validating
Get validated value early enough

@s-hertel s-hertel force-pushed the s-hertel:fix_handler_listeners branch from 282ccb7 to 4cc21dd Apr 24, 2019

@ansibot ansibot added core_review and removed needs_revision labels Apr 26, 2019

@ansibot ansibot added the stale_ci label May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.