From e6ba8a063187db178ed9db76691e2e34139ee5fb Mon Sep 17 00:00:00 2001 From: Bojan Vitnik Date: Tue, 23 Apr 2019 02:53:07 +0200 Subject: [PATCH 1/2] XenServer: Minor changes and fixes in xenserver_guest - xenserver_guest module: ignore wait_for_ip_address when state=absent (fixes #55348). Module docs are updated to reflect this. - xenserver_guest module: show proper error message when maximum number of network interfaces is reached and multiple network interfaces are added at once (fix for changes introduced in #54697). - xenserver_guest module: fixed a bug in reconfigure() where VM would be powered off even though check mode is used when reconfiguration needs VM to be powered off. --- .../modules/cloud/xenserver/xenserver_guest.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/ansible/modules/cloud/xenserver/xenserver_guest.py b/lib/ansible/modules/cloud/xenserver/xenserver_guest.py index eaaabdf1ace3cf..3ac13beade93bd 100644 --- a/lib/ansible/modules/cloud/xenserver/xenserver_guest.py +++ b/lib/ansible/modules/cloud/xenserver/xenserver_guest.py @@ -169,7 +169,7 @@ type: list wait_for_ip_address: description: - - Wait until XenServer detects an IP address for the VM. + - Wait until XenServer detects an IP address for the VM. If C(state) is set to C(absent), this parameter is ignored. - This requires XenServer Tools to be preinstalled on the VM to work properly. type: bool default: no @@ -597,16 +597,16 @@ def reconfigure(self): vm_power_state_save = self.vm_params['power_state'].lower() - if "need_poweredoff" in config_changes and vm_power_state_save != 'halted': - if self.module.params['force']: - self.set_power_state("shutdownguest") - else: - self.module.fail_json(msg="VM reconfigure: VM has to be in powered off state to reconfigure but force was not specified!") + if "need_poweredoff" in config_changes and vm_power_state_save != 'halted' and not self.module.params['force']: + self.module.fail_json(msg="VM reconfigure: VM has to be in powered off state to reconfigure but force was not specified!") # Support for Ansible check mode. if self.module.check_mode: return config_changes + if "need_poweredoff" in config_changes and vm_power_state_save != 'halted' and self.module.params['force']: + self.set_power_state("shutdownguest") + try: for change in config_changes: if isinstance(change, six.string_types): @@ -1632,6 +1632,7 @@ def get_changes(self): if vif_device not in vif_devices_allowed: self.module.fail_json(msg="VM check networks[%s]: new network interface position %s is out of bounds!" % (position, vif_device)) + vif_devices_allowed.remove(vif_device) vif_device_highest = vif_device # For new VIFs we only track their position. @@ -1911,7 +1912,7 @@ def main(): vm.deploy() result['changed'] = True - if module.params['wait_for_ip_address']: + if module.params['wait_for_ip_address'] and module.params['state'] != "absent": vm.wait_for_ip_address() result['instance'] = vm.gather_facts() From 7f9934cfbc2f5bbf7cf88bfb1d07f2140bbdd252 Mon Sep 17 00:00:00 2001 From: Bojan Vitnik Date: Wed, 24 Apr 2019 01:36:38 +0200 Subject: [PATCH 2/2] Added changelog fragment --- ...uest-change-wait_for_ip_address-behaviour-and-other.yaml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 changelogs/fragments/55678-xenserver_guest-change-wait_for_ip_address-behaviour-and-other.yaml diff --git a/changelogs/fragments/55678-xenserver_guest-change-wait_for_ip_address-behaviour-and-other.yaml b/changelogs/fragments/55678-xenserver_guest-change-wait_for_ip_address-behaviour-and-other.yaml new file mode 100644 index 00000000000000..76a63024b02733 --- /dev/null +++ b/changelogs/fragments/55678-xenserver_guest-change-wait_for_ip_address-behaviour-and-other.yaml @@ -0,0 +1,6 @@ +minor_changes: + - xenserver_guest - wait_for_ip_address is now ignored when state=absent (https://github.com/ansible/ansible/issues/55348). + +bugfixes: + - xenserver_guest - proper error message is shown when maximum number of network interfaces is reached and multiple network interfaces are added at once. + - xenserver_guest - fixed an issue where VM whould be powered off even though check mode is used if reconfiguration requires VM to be powered off.