Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url lookup: add user agent option; use consistent default #55733

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@scottsb
Copy link
Contributor

commented Apr 24, 2019

SUMMARY

Add ability to set user agent with URL lookup. At the same time, apply a default of ansible-httpget to match the URL module and various other modules that do HTTP requests.

The change in default is particularly useful because otherwise the default Python user agent of Python-urllib* is used, which can end up blocked by the OWASP ModSecurity ruleset. As a particular example, this currently blocks simple retrieval of Cloudflare IP ranges.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

url

ADDITIONAL INFORMATION

n/a

@scottsb

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

ready_for_review

Think this test failure is not caused by this PR.

@bcoca
Copy link
Member

left a comment

LGTM but needs version change, also a changelog would be nice (minor_change)

description: Header to identify as, generally appears in web server logs.
type: string
default: ansible-httpget
version_added: "2.8"

This comment has been minimized.

Copy link
@bcoca

bcoca Apr 25, 2019

Member

2.9 at this point

@bcoca bcoca removed the needs_triage label Apr 25, 2019

@ansibot ansibot added the stale_ci label May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.