Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New modules for Azure policy set definition #55791

Open
wants to merge 6 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@MyronFanQiu
Copy link
Contributor

commented Apr 26, 2019

SUMMARY

azure_rm_policysetdefinition: create, update and delete the Azure policy set definition.
azure_rm_policysetdefinition_facts: list the info for a specific policy definition or all policy set definitions.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_policysetdefinition

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

@MyronFanQiu this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

@MyronFanQiu, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

@ansibot ansibot added the stale_ci label May 5, 2019


DOCUMENTATION = '''
---
module: azure_rm_policysetdefinition

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

the name is policysetdefinition, not policydefinition? is it from sdk model name?

This comment has been minimized.

Copy link
@MyronFanQiu

MyronFanQiu May 7, 2019

Author Contributor

There are three modules about policy, which are policy definition, policy assignment and policy set definition. There is another PR about policy definition.

required: true
management_group:
description:
- The ID of the management group.

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

is it a azure resource id? how to get the management_group id?

This comment has been minimized.

Copy link
@MyronFanQiu

MyronFanQiu May 7, 2019

Author Contributor

It isn't the azure resource id. This link explain the management group. Perhaps, a new module for the management group is suitable?

Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_policysetdefinition.py
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_policysetdefinition.py
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_policysetdefinition.py
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_policysetdefinition_facts.py Outdated
- Resource type
sample: "Microsoft.Authorization/policySetDefinitions"
type: str
policy_definitions:

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

what's the difference of the id in policy_defintions with id field?

This comment has been minimized.

Copy link
@MyronFanQiu

MyronFanQiu May 7, 2019

Author Contributor

Just as the name. The policy setdefinition is a set of policy definitions. So the id in the policy_definitions is the id of the policy definition. The id field is the id of the policy setdefinition.

Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_policysetdefinition_facts.py Outdated
self.management_group = None
self.built_in = None

mutually_exclusive = [('management_group', 'built_in')]

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

add description of mutual exclusive in docs

azure_rm_policysetdefinition:
name: "{{ policy_set_name }}"
policy_definitions: '[
{

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

hardcode guid?

@ansibot ansibot removed the needs_triage label May 7, 2019

@ansibot ansibot removed the stale_ci label May 7, 2019

@ansibot ansibot added the stale_ci label May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.