Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.8 backport :fix bugs for ce (#54750) #55861

Open
wants to merge 3 commits into
base: stable-2.8
from

Conversation

Projects
None yet
2 participants
@xuxiaowei0512
Copy link
Contributor

commented Apr 28, 2019

(cherry picked from commit 1017f15)

SUMMARY

stable-2.8 backport #54750

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/network/cloudengine/ce.py
lib/ansible/modules/network/cloudengine/ce_aaa_server.py
lib/ansible/modules/network/cloudengine/ce_aaa_server_host.py
lib/ansible/modules/network/cloudengine/ce_command.py
lib/ansible/modules/network/cloudengine/ce_facts.py
lib/ansible/modules/network/cloudengine/ce_netconf.py
lib/ansible/modules/network/cloudengine/ce_vlan.py
lib/ansible/plugins/action/ce.py

ADDITIONAL INFORMATION

xuxiaowei0512 added some commits Apr 17, 2019

fix bugs for ce (#54750)
* Update ce.py

            while to_text(out, errors='surrogate_then_replace').strip().endswith(']'):
                display.vvvv('wrong context, sending exit to device', self._play_context.remote_addr)
                conn.exec_command('return')
                out = conn.get_prompt()

connetion has no send_command function and ce device has no 'exit' command to return user-view(a correct context),but 'return' .command.

* Add files via upload

Some bugs fix.

* Add files via upload

fix some bugs

* fix a bug for ce_command

Running a command with prompt via ce_command, It doesn't work.The reason is that the key word for network_cli recognition is answer not response.

* fix bugs

fix bugs for ce modules

* Update ce.py

* Delete ce_ftp.py

need modify

* Delete ce_lacp.py

* Add files via upload

* Delete ce_aaa_server.py

* Delete ce_aaa_server_host.py

* Compatible with Python 3

Compatible with Python 3 and fix bugs for ce

* Update ce_aaa_server.py

* Add files via upload

modify doc

* Add files via upload

Compatible with Python 3 and fix bugs

* Add files via upload

Compatible with Python 3 and fix bugs

* Add files via upload

Cancellation of change

* Update ce_netconf.py

It is a bug that response has no xml attribute:line 183

* Add files via upload

* Add files via upload

Compatible with Python 3 and fix bugs

* updatp ce_config.py

a bug for this module.

(cherry picked from commit 1017f15)
add changelogs fragment
add changelog  fragment
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

cc @CloudEngine-Ansible @QijunPan
click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2019

@xuxiaowei0512, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

update changelogs
changelogs/fragments/54750-fix_bugs_for_ce.yml:0:0: use "\n" for line endings instead of "\r\n"

@xuxiaowei0512 xuxiaowei0512 changed the title backport:fix bugs for ce (#54750) 2.8 backport :fix bugs for ce (#54750) Apr 29, 2019

@xuxiaowei0512 xuxiaowei0512 marked this pull request as ready for review Apr 29, 2019

@ansibot ansibot added the stale_ci label May 7, 2019

@xuxiaowei0512 xuxiaowei0512 reopened this May 7, 2019

@ansibot ansibot removed the stale_ci label May 7, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Components

changelogs/fragments/54750-fix_bugs_for_ce.yml
support: community
maintainers:

lib/ansible/module_utils/network/cloudengine/ce.py
support: community
maintainers: QijunPan

lib/ansible/modules/network/cloudengine/ce_aaa_server.py
support: community
maintainers: QijunPan

lib/ansible/modules/network/cloudengine/ce_aaa_server_host.py
support: community
maintainers: QijunPan

lib/ansible/modules/network/cloudengine/ce_command.py
support: community
maintainers: CloudEngine-Ansible QijunPan

lib/ansible/modules/network/cloudengine/ce_config.py
support: community
maintainers: QijunPan

lib/ansible/modules/network/cloudengine/ce_facts.py
support: community
maintainers: QijunPan

lib/ansible/modules/network/cloudengine/ce_netconf.py
support: community
maintainers: QijunPan

lib/ansible/modules/network/cloudengine/ce_vlan.py
support: community
maintainers: QijunPan

lib/ansible/plugins/action/ce.py
support: community
maintainers:

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: blocked
shippable_status: success
maintainer_shipits (module maintainers): 0
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainer or core team member): []
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@xuxiaowei0512

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.