Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxmox_kvm add `disk` option #55874

Open
wants to merge 4 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@helldorado
Copy link
Contributor

commented Apr 29, 2019

SUMMARY

@LaurentDumont @killswitch-GUI @fredmiranda @berendt @xoxys this PR Fix issues #40921 #41940 #32294 #28277

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

proxmox_kvm

ANSIBLE VERSION
ansible --version
ansible 2.7.10
  config file = None
  configured module search path = ['/Users/helldorado/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.7.3 (default, Apr 15 2019, 10:52:16) [Clang 10.0.1 (clang-1001.0.46.3)]
ADDITIONAL INFORMATION

Note: For the parameter pause, we recommand using option pause in loop_control which allows you to control the time (in seconds) between execution of items in a task loop. Cf https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#loop-control

For testing the PR before Merged you can download directly module from https://github.com/helldorado/ansible/blob/devel/lib/ansible/modules/cloud/misc/proxmox_kvm.py and put in playbooks/library/proxmox_kvm.py

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

helldorado added some commits Apr 29, 2019

@gundalow gundalow added feature and removed bug labels Apr 30, 2019

@gundalow gundalow changed the title Reopen new PR from closed PR #42313 with fix MR conflict -- This PR fix… proxmox_kvm add `disk` option Apr 30, 2019

@gundalow

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

@LaurentDumont @killswitch-GUI @fredmiranda @berendt @xoxys @joshainglis @karmab Hi, I believe this fixes an issue in proxyox_kvm that you might be interested in, was wondering if you might be able to take a look at this PR to see if it's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.