Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New modules for Azure diagnostic settings #55905

Open
wants to merge 10 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@MyronFanQiu
Copy link
Contributor

commented Apr 30, 2019

SUMMARY

azure_rm_diagnosticsettings: create, update and delete the Azure diagnostic settings.
azure_rm_diagnosticsettings_facts: Gather the info for Azure diagnostic settings.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_diagnosticsettings

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@MyronFanQiu this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@MyronFanQiu, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@ansibot ansibot added the test label Apr 30, 2019

@MyronFanQiu MyronFanQiu force-pushed the VSChina:fanqiu-diagnostic-settings branch from 9307f40 to 03eac25 Apr 30, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@MyronFanQiu MyronFanQiu force-pushed the VSChina:fanqiu-diagnostic-settings branch from 2f00534 to d58bc0e May 5, 2019

@MyronFanQiu MyronFanQiu changed the title [WIP] New modules for Azure diagnostic settings New modules for Azure diagnostic settings May 5, 2019

@ansibot ansibot removed the WIP label May 6, 2019

Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_diagnosticsettings.py Outdated
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_diagnosticsettings.py Outdated
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_diagnosticsettings.py Outdated
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_diagnosticsettings.py Outdated
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_diagnosticsettings.py Outdated
Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_diagnosticsettings.py Outdated
event_hub_authorization_rule_id:
description:
- The resource Id for the event hub authorization rule.
event_hub_name:

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

pls support id also

This comment has been minimized.

Copy link
@MyronFanQiu

MyronFanQiu May 7, 2019

Author Contributor

The python sdk needs the name of the event hub, and I think it's the simplest way to provide this information. For other fields, it supports both id or the name + resource_group now.

Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_diagnosticsettings.py Outdated
- The type of the diagnostic settings category. Possible values include 'Metrics' and 'Logs'
returned: always
type: str
example: "Logs"

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

what user should pass in in main module for category? logs?

This comment has been minimized.

Copy link
@MyronFanQiu

MyronFanQiu May 7, 2019

Author Contributor

For the type of the category, two possible values are Logs and Metrics. In the main module, two parameters named logs and metrics are available for user to set. It's consistent with the az cli.

This comment has been minimized.

Copy link
@MyronFanQiu

MyronFanQiu May 7, 2019

Author Contributor

Actually, I think the word category is a little bit far from diagnostic settings. The word metrics and logs are more meaningful for user in the main module.

MyronFanQiu added some commits May 7, 2019

self.storage_account = storage_account

def format_workspace_id(self):
workspace = self.workspace

This comment has been minimized.

Copy link
@yuwzho

yuwzho May 10, 2019

Contributor

also need to check whether the workspace is name or resource id

@ansibot ansibot added the stale_ci label May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.