Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Configure setup() to use setup.cfg file #55923

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@pabelanger
Copy link
Contributor

commented Apr 30, 2019

SUMMARY

Create setup.cfg file so automation tools can learn more about ansible.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

This affect setup.py

ADDITIONAL INFORMATION

Today zuul will parse the setup.cfg file to learn more abount a python project, this is an example of how we can do more cross-project testing with ansible/ansible.

Configure setup() to use setup.cfg file
Since setuptool 30.3.0, it is possible to leverage things in setup.cfg.
This is helpful for automation tools which might want to parse setup.cfg
to learn about the python project.  Move some of our items out of
setup.py and into setup.cfg.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

pabelanger added a commit to pabelanger/network that referenced this pull request Apr 30, 2019

DNM: add zuul vyos testing
This is an example job to start testing vyos

Depends-On: ansible/ansible-zuul-jobs#34
Depends-On: ansible/ansible#55589
Depends-On: ansible/ansible#55923

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

pabelanger added a commit to pabelanger/network that referenced this pull request Apr 30, 2019

DNM: add zuul vyos testing
This is an example job to start testing vyos

Depends-On: ansible/ansible-zuul-jobs#34
Depends-On: ansible/ansible#55589
Depends-On: ansible/ansible#55923

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

@ansibot ansibot added needs_revision and removed core_review labels Apr 30, 2019

@samdoran samdoran removed the needs_triage label Apr 30, 2019

@samdoran samdoran requested review from sivel, abadger and nitzmahone and removed request for sivel Apr 30, 2019

@sivel

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

I don't think we can do this. As indicated in the commit, this requires setuptools 30.3.0, and Not all distros we support ship with this:

RHEL7: 0.9.8
Ubuntu 16.04: 20.7.0-1

It seems to also be causing some issues in CI as well.

We might be able to have a setup.cfg, but it would have to be in addition to what we already, effectively duplicating information.

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

Yah, that's what i wanted to check with CI first. See what breaks, what works. This is very much WIP ATM

@sivel sivel changed the title Configure setup() to use setup.cfg file [WIP] Configure setup() to use setup.cfg file Apr 30, 2019

@sivel

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@pabelanger Thanks. I've updated the title to include [WIP] so that we have a visual indicator of such.

@ansibot ansibot added the WIP label Apr 30, 2019

@ansibot ansibot added the stale_ci label May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.