Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt_vm: Improve create VM from template #55927

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
5 participants
@machacekondra
Copy link
Contributor

commented Apr 30, 2019

SUMMARY

Improve creating VM from template. Merge VM disks/interfaces with the template defaults.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubevirt_vm

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@pkliczewski

This comment has been minimized.

Copy link

commented Apr 30, 2019

@machacekondra pylint is complaing please fix.

@ansibot ansibot removed the needs_triage label Apr 30, 2019

@machacekondra machacekondra force-pushed the machacekondra:fix_kubevirt_template branch from 426fdfa to 2c7f4b2 May 2, 2019

@machacekondra

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Fixes: #54900

@ansibot ansibot added the stale_ci label May 10, 2019

@pkliczewski

This comment has been minimized.

Copy link

commented May 10, 2019

+1

@machacekondra

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

Components

lib/ansible/module_utils/kubevirt.py
support: community
maintainers: machacekondra mmazur pkliczewski

lib/ansible/modules/cloud/kubevirt/kubevirt_vm.py
support: community
maintainers: kubevirt machacekondra mmazur pkliczewski

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): pkliczewski machacekondra
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@mmazur

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

+1

@machacekondra

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2019

@Akasurde Can you please review/merge?

@mmazur

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Components

lib/ansible/module_utils/kubevirt.py
support: community
maintainers: machacekondra mmazur pkliczewski

lib/ansible/modules/cloud/kubevirt/kubevirt_vm.py
support: community
maintainers: kubevirt machacekondra mmazur pkliczewski

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 3
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): pkliczewski mmazur machacekondra
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@machacekondra

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

shipit

@machacekondra

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Components

lib/ansible/module_utils/kubevirt.py
support: community
maintainers: machacekondra mmazur pkliczewski

lib/ansible/modules/cloud/kubevirt/kubevirt_vm.py
support: community
maintainers: kubevirt machacekondra mmazur pkliczewski

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 3
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): pkliczewski mmazur machacekondra
shipit_actors_other: []
automerge: automerge ci_stale test failed

click here for bot help

@machacekondra machacekondra force-pushed the machacekondra:fix_kubevirt_template branch from 2c7f4b2 to 18a8b75 May 20, 2019

@ansibot ansibot added community_review and removed shipit labels May 20, 2019

@machacekondra

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

shipit

@machacekondra

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Components

lib/ansible/module_utils/kubevirt.py
support: community
maintainers: machacekondra mmazur pkliczewski

lib/ansible/modules/cloud/kubevirt/kubevirt_vm.py
support: community
maintainers: kubevirt machacekondra mmazur pkliczewski

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 1
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): machacekondra
shipit_actors_other: []
automerge: automerge shipit test failed

click here for bot help

@mmazur

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

shipit

@mmazur

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

bot_status

@mmazur

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@mattclay the bot went full skynet, we don't know what it wants, can you help?

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Components

lib/ansible/module_utils/kubevirt.py
support: community
maintainers: machacekondra mmazur pkliczewski

lib/ansible/modules/cloud/kubevirt/kubevirt_vm.py
support: community
maintainers: kubevirt machacekondra mmazur pkliczewski

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): machacekondra mmazur
shipit_actors_other: []
automerge: automerge !module file(s) test failed

click here for bot help

@ansibot ansibot added shipit and removed community_review labels May 20, 2019

@Akasurde

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@mkrizek might help you here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.