Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction in the line 309 of the azure_rm.py script #55937

Open
wants to merge 1 commit into
base: devel
from
Open
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -306,7 +306,7 @@ def __init__(self, args):
else:
# try to look up "well-known" values via the name attribute on azure_cloud members
all_clouds = [x[1] for x in inspect.getmembers(azure_cloud) if isinstance(x[1], azure_cloud.Cloud)]
matched_clouds = [x for x in all_clouds if x.name == raw_cloud_env]
matched_clouds = [x for x in all_clouds if x.name == raw_cloud_env.name]

This comment has been minimized.

Copy link
@yuwzho

yuwzho May 5, 2019

Contributor

Please also replace the raw_cloud_env this in the following context

This comment has been minimized.

Copy link
@AlexonOliveiraRH

AlexonOliveiraRH May 29, 2019

Author

@yuwzho I already applied that change in my fork, tested in the customer environment successfully and I'm just waiting for the approval to merge it to the branch. Thank you.

if len(matched_clouds) == 1:
self._cloud_environment = matched_clouds[0]
elif len(matched_clouds) > 1:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.