Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netbox Inventory enchancement - add Device and VM Interface information #55982

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@mkeetman
Copy link

commented May 1, 2019

SUMMARY

This PR implements a new extractor method which includes the inventory information if requested. Additionally, it makes a second request to gather all device/vm IP addresses and attaches them as a list to the interface object

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

Netbox inventory plugin

ADDITIONAL INFORMATION

The inventory extraction is quite expensive and slow. The Netbox API doesn't appear to lend itself to easy access to this information (except requesting each interface individually)

This PR supersedes #54285 which had gotten out of hand due to my inexperience.

Keetman, Michael
@ansibot

This comment has been minimized.

@FragmentedPacket
Copy link
Contributor

left a comment

Tested and looks good.

@ansibot ansibot removed the needs_triage label May 3, 2019

@ansibot ansibot added the stale_ci label May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.