Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_bucket: add encryption capabilities to the module #55985

Open
wants to merge 14 commits into
base: devel
from

Conversation

Projects
None yet
6 participants
@stefanhorning
Copy link
Contributor

commented May 1, 2019

SUMMARY

Adds encryption capabilities to the s3_bucket module. Based on this PR #38538

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

s3_bucket

ADDITIONAL INFORMATION

Includes all change sfrom @julienvey made in PR #38538 and the changes from @wimnat made in his branch https://github.com/ansible/ansible/compare/devel...wimnat:s3_encryption?expand=1 and resolving of merge conflicts by me. To hopefully get this all into a mergable state.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@stefanhorning this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@stefanhorning, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@willthames

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

Looks good, I'll run the test suite

@ansibot ansibot removed the needs_triage label May 1, 2019

@stefanhorning stefanhorning force-pushed the mediapeers:s3_encryption branch from 935f387 to 4b42cc5 May 1, 2019

@stefanhorning

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

I rebased this branch once more and resolved the last merging glitches now. @willthames also added the requested line break. So I guess this is ready to merge now.

@stefanhorning

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

cc @wimnat @ryansb @s-hertel (previous reviewers)

@stefanhorning

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

ready_for_review

@ansibot ansibot added the stale_ci label May 17, 2019

@jillr
Copy link
Contributor

left a comment

tests good for me, thanks for this patch.

Show resolved Hide resolved lib/ansible/modules/cloud/amazon/s3_bucket.py Outdated

@ansibot ansibot added needs_revision and removed core_review labels May 20, 2019

@stefanhorning

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@jillr Added the linebreak as suggested.

To everyone else: if there is no more linebreaks to add, please merge.

@ansibot ansibot removed the stale_ci label May 21, 2019

@jillr

jillr approved these changes May 21, 2019

@jillr
Copy link
Contributor

left a comment

Once sanity tests pass, lgtm

@stefanhorning

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

Sanity tests are green now. But somehow integration tests started failing out of the blue. Was there recent changes in the test environment in regards to AWS s3 permissions? If so they need to be rolled back to make the tests in here green again.

@stefanhorning stefanhorning force-pushed the mediapeers:s3_encryption branch from 760829e to 39159d6 May 24, 2019

@stefanhorning

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Rebased on latest devel to see if that fixes build issues.

stefanhorning added some commits May 24, 2019

Added s3:HeadBucket action to list, seems to get used in failing test…
…s, eventhough this PR doesn't change anything in this regard
Reverted change in storage-policy.json, use bucket names with dashes …
…in integration test. Also added another pause to make tests run smoothly also in the aws docker envs

@ansibot ansibot added core_review and removed needs_revision labels May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.