Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for k8s cascading deletes #55987

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@willthames
Copy link
Contributor

commented May 1, 2019

SUMMARY

Fix up test suite for k8s module (including a minor bug highlighted in the waiter test suite) and add tests for cascading delete

Note that cascading deletes do work in the background, but checking immediately after a delete, even with wait: yes is likely to be too quick. Foreground deletes have been disabled even in kubectl as too dangerous (they can just hang forever in certain circumstances)

Relies on #56166 and #56168

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s

ADDITIONAL INFORMATION
@willthames

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

WIP for now - the test case demonstrates the issue. This will almost certainly need openshift-restclient-python changes, even though it would be nice if that weren't the case.

@ansibot

This comment has been minimized.

@fabianvf

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

You may be able to set the delete strategy by passing in a query parameter to the request, although the longer-term correct solution would probably be to accept a v1.DeleteOptions object/definition in the delete method.

@ansibot ansibot removed the needs_triage label May 1, 2019

@willthames

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

Thanks @fabianvf, I'll have a look at trying that tonight.

@willthames willthames force-pushed the willthames:issue-42302 branch 2 times, most recently from 5e8eb5e to 41666d9 May 7, 2019

@willthames willthames changed the title WIP: Fix non-cascading deletes Add test case for k8s cascading deletes May 7, 2019

@willthames willthames force-pushed the willthames:issue-42302 branch 2 times, most recently from 671c878 to dbb69d1 May 7, 2019

@willthames

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Test failures don't appear to be related to this change (lack of coverage?) and I'm fairly certain tests weren't passing before these changes.

@willthames willthames removed the WIP label May 7, 2019

@ansibot ansibot added the stale_ci label May 16, 2019

Add test case for non-cascading deletes
Deleting a DaemonSet does not delete associated pods,
even though it should

@willthames willthames force-pushed the willthames:issue-42302 branch from dbb69d1 to 8d28431 May 18, 2019

@ansibot ansibot removed the stale_ci label May 18, 2019

Add coverage module when using pip
Otherwise tests seemingly fail
@willthames

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2019

This relies on #56166 being merged before it will pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.