Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nxos_install_os: Fix nxapi local failures #55993

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@mikewiebe
Copy link
Contributor

commented May 1, 2019

SUMMARY

Fixes the following issues for nxos_install_os in the devel branch
* Recent refactoring in module_utils broke upgrades using nxapi local
* Refactored integration tests to make them more flexible for choosing connection type

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

nxos_install_os

ADDITIONAL INFORMATION

Please cherry-pick into stable-2.8

@mikewiebe mikewiebe changed the title Fix nxapi failures nxos_install_os: Fix nxapi local failures May 1, 2019

@ansibot

This comment has been minimized.

@mikewiebe mikewiebe force-pushed the mikewiebe-ansible:rel280/fix_nxos_install_os branch from f84b28a to bbb2a33 May 8, 2019

@mikewiebe

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@trishnaguha I fixed the conflicts with the base branch here.

msg = self.send_request(commands, output='config', check_status=True,
return_error=return_error, opts=opts)
try:
resp, msg_timestamps = self.send_request(commands, output='config', check_status=True,

This comment has been minimized.

Copy link
@trishnaguha

trishnaguha May 10, 2019

Member

As the return_timestamps is reverted, msg_timestamps is not needed anymore. lgtm otherwise.

@ansibot ansibot removed the core_review label May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.