Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install hidden galaxy data files (e.g. .travis.yml) #56005

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@jdennis
Copy link

commented May 1, 2019

The package_data globs in setup.py were missing the necessary glob
to install:

galaxy/data/default/.travis.yml

A Python glob pattern will not by default match a hidden file
(i.e. a file basename beginning with a dot). If you want a glob
to pick up a hidden file in a directory you must explicitly specify
a glob pattern with "/.*".

Closes: #1777
Signed-off-by: John Dennis jdennis@redhat.com

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

Install hidden galaxy data files (e.g. .travis.yml)
The package_data globs in setup.py were missing the necessary glob
to install:

galaxy/data/default/.travis.yml

A Python glob pattern will not by default match a hidden file
(i.e. a file basename beginning with a dot). If you want a glob
to pick up a hidden file in a directory you must explicitly specify
a glob pattern with "/.*".

Closes: #1777
Signed-off-by: John Dennis <jdennis@redhat.com>
@nitzmahone
Copy link
Member

left a comment

In this case, we should probably add the specific files in question, just to avoid the possibility of packaging things we shouldn't...

@nitzmahone nitzmahone added P2 P3 and removed needs_triage P2 labels May 2, 2019

@ansibot ansibot added needs_revision and removed core_review labels May 2, 2019

@ansibot ansibot added the stale_ci label May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.