Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg facts apt fix #56008

Open
wants to merge 2 commits into
base: stable-2.8
from

Conversation

Projects
None yet
4 participants
@bcoca
Copy link
Member

commented May 2, 2019

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

module/package_facts

MrKich and others added some commits May 1, 2019

Package facts apt fix (#55963)
* fixes for apt on package_facts

* reverse order, apt is newer

* moved warnings prop to base

(cherry picked from commit 24a46de)
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@@ -18,6 +18,8 @@ def get_all_pkg_managers():

class PkgMgr(with_metaclass(ABCMeta, object)):

warnings = []

This comment has been minimized.

Copy link
@samdoran

samdoran May 20, 2019

Member

I'm not sure it makes sense to add this is as a class attribute. Warnings aren't inherently something related to a PkgMgr object.

Should we create a global value to hold warning state, then process the warning state in fail_json() or exit_json()?

This comment has been minimized.

Copy link
@bcoca

bcoca May 20, 2019

Author Member

so module.warn?

This comment has been minimized.

Copy link
@samdoran

samdoran May 20, 2019

Member

Pretty much. But without the need for a module instance. This would give us a better place to keep warnings than adding a new attribute here.

This comment has been minimized.

Copy link
@bcoca

bcoca May 20, 2019

Author Member

w/o module it cannot be processed in fail_json/exit_json automatically, that is why i did it this way, still works in similar fashion

@ansibot ansibot removed the needs_triage label May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.