Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cnos_vrf.py to to fix coverity bug. #56014

Open
wants to merge 8 commits into
base: stable-2.8
from

Conversation

Projects
None yet
3 participants
@amuraleedhar
Copy link
Contributor

commented May 2, 2019

(cherry picked from commit ac54645)

SUMMARY

Cherry-pick #55954 to 2.8.x
This changes are pertaining to fix for coverity bugs ran against cnos modules

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib//ansible/modules/network/cnos/cnos_vrf.py

ADDITIONAL INFORMATION

Pasted below is the coverity issue which I am trying address

def map_config_to_obj(module):
229 objs = []
230 output = run_commands(module, {'command': 'show vrf'})
Condition output === None, taking true branch.
null_check: Comparing output to a null-like value implies that output might be null-like.
231 if output is None:
232 module.fail_json(msg='Could not fetch VRF details from device')
CID 80685 (#1 of 1): Bad use of null-like value (FORWARD_NULL)3. property_access: Accessing a property of null-like value output.
233 vrfText = output[0].strip()

amuraleedhar added some commits Apr 30, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Hi, backports need a changelog fragment before being merged. Once that's added I can merge this for the next 2.8.x release.

@ansibot ansibot removed the needs_triage label May 20, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@amuraleedhar this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@amuraleedhar

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

Added changelog fragment too

amuraleedhar added some commits May 20, 2019

@ansibot ansibot removed the owner_pr label May 20, 2019

@amuraleedhar

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2019

Why it is getting cancelled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.