Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

na_ontap_volume - added qos policy module options #56026

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@vicmunoz
Copy link
Contributor

commented May 2, 2019

SUMMARY

Added new options:
-- qos_policy_group
-- qos_adaptive_policy_group

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

na_ontap_volume

@ansibot

This comment has been minimized.

@ansibot ansibot removed the needs_triage label May 3, 2019

@carchi8py
Copy link
Contributor

left a comment

Can we limit the change to just adding the qos policy necessary changes?

@vicmunoz

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

Other changes added are just pylint recommendations or similar. Is it ok for you or prefer to remove them?

@carchi8py

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

Which one are pylint recommendations?

and are you running the standard pylint or the modify one ansible uses
ansible-test sanity --docker=default --test pylint

@vicmunoz

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

alignments, lines too long...
I've executed pylint standard. I didn't know ansible pylint.
I'll review and check using ansible sanity test from now on

@lonico

lonico approved these changes May 7, 2019

Copy link
Contributor

left a comment

shipit

Show resolved Hide resolved lib/ansible/modules/storage/netapp/na_ontap_volume.py Outdated

@ansibot ansibot removed the new_contributor label May 8, 2019

@thedoubl3j
Copy link
Contributor

left a comment

if we could get a couple of examples of the new features added in, that would be great

@vicmunoz

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

updated details and examples

@thedoubl3j

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

@carchi8py @lonico please re ship it when you get a moment to review.

@lonico

lonico approved these changes May 15, 2019

Copy link
Contributor

left a comment

shipit

@lonico

lonico approved these changes May 17, 2019

Copy link
Contributor

left a comment

Shipit

@thedoubl3j
Copy link
Contributor

left a comment

examples added for both, lgtm.

@thedoubl3j

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

shipit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.