Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access key option for azure_rm_storageblob #56095

Open
wants to merge 10 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@MyronFanQiu
Copy link
Contributor

commented May 5, 2019

SUMMARY

Add access key option for azure_rm_storageblob. It can making requests to the storage account in other subscription with access key. Fixes #55350

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_storageblob

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 5, 2019

@MyronFanQiu, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Fred-sun

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@yungezz @yuwzho @zikalino Please review this PR when you're available! Thanks a lot!

@MyronFanQiu MyronFanQiu closed this May 7, 2019

@MyronFanQiu MyronFanQiu reopened this May 7, 2019

Show resolved Hide resolved lib/ansible/modules/cloud/azure/azure_rm_storageblob.py Outdated
@@ -111,6 +111,11 @@
choices:
- container
- blob
access_key:
description:
- Use access key to authenticate your applications.

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

can we add function in storage module to generate sas?

@MyronFanQiu

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

I delete the required field for C(resource_group), add the required_one_of constrain and update the documentation. If the module supports the shared_access_key, the resource_group is no longer required.

MyronFanQiu added some commits May 13, 2019

MyronFanQiu added some commits May 13, 2019

@MyronFanQiu MyronFanQiu reopened this May 14, 2019

@yuwzho

yuwzho approved these changes May 15, 2019

@yuwzho

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

shipit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.