Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent vars premature templating #56117

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@bcoca
Copy link
Member

commented May 6, 2019

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

core

@mkrizek

mkrizek approved these changes May 6, 2019

@bcoca bcoca force-pushed the bcoca:prevent_vars_premature_t branch from 182bc7a to 2636f36 May 6, 2019

@bcoca bcoca changed the title Prevent vars premature templating [WIP] Prevent vars premature templating May 9, 2019

@ansibot ansibot added the WIP label May 9, 2019

@samdoran samdoran removed the needs_triage label May 14, 2019

@samdoran

This comment has been minimized.

Copy link
Member

commented May 14, 2019

I believe it was discussed with @sivel that this can be closed.

@ansibot ansibot added the stale_ci label May 14, 2019

bcoca added some commits May 6, 2019

avoid premature vars templating
  added tests
  avoid 'is template' warning in vars, since we want them for latter templating

ci_complete
forgot aliases
ci_complete

@bcoca bcoca force-pushed the bcoca:prevent_vars_premature_t branch from b86aec6 to b7390d2 May 14, 2019

@bcoca bcoca changed the title [WIP] Prevent vars premature templating Prevent vars premature templating May 14, 2019

@bcoca

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

rediscussed, now using correct test

@ansibot ansibot removed WIP stale_ci labels May 14, 2019

set -eux

# this should succeed since we override the undefined variable
ansible-playbook undefined.yml -i inventory -v "$@" -e '{"mytest": False}'

This comment has been minimized.

Copy link
@mkrizek

mkrizek May 15, 2019

Contributor

It should succeed even if we don't override the undefined variable.

@ansibot ansibot added needs_revision and removed core_review labels May 15, 2019

@ansibot ansibot removed the needs_revision label May 16, 2019

@ansibot ansibot added the core_review label May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.