Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_guest_facts: do not enforce the datacenter parameter #56132

Conversation

Projects
None yet
3 participants
@goneri
Copy link
Contributor

commented May 6, 2019

SUMMARY

There is no reason to enforce the presence of the datacenter parameter.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest_facts

@goneri goneri force-pushed the goneri:vmware_guest_facts_without_datastore_parameters branch from 6fc927d to 1804c97 May 6, 2019

@ansibot

This comment has been minimized.

@goneri goneri changed the title vmware_guest_facts: do not enforce the datastore parameter vmware_guest_facts: do not enforce the datacenter parameter May 6, 2019

vmware_guest_facts: do not enforce the datacenter parameter
There is no reason to enforce the presence of the datacenter parameter.

@goneri goneri force-pushed the goneri:vmware_guest_facts_without_datastore_parameters branch from 1804c97 to d04038e May 6, 2019

goneri added a commit to goneri/ansible-role-vcenter-instance that referenced this pull request May 6, 2019

@Akasurde
Copy link
Member

left a comment

no-go from my side.

@@ -70,7 +70,7 @@
datacenter:
description:
- Destination datacenter for the deploy operation
required: True
required: False

This comment has been minimized.

Copy link
@Akasurde

Akasurde May 7, 2019

Member

Datacenter parameter is used in get_vm API, so I would say this is a required parameter.

This comment has been minimized.

Copy link
@goneri

goneri May 7, 2019

Author Contributor

It works without, but it may be an unexpected side effect.

Could we default the datacenter value to ha-datacenter? This way we don't enforce the presence of the parameter and we come with reasonable default value instead.

This comment has been minimized.

Copy link
@Akasurde

Akasurde May 8, 2019

Member

Setting default value to ha-datacenter results in unwanted outputs as people tend to forget to provide value as it is not required.

This comment has been minimized.

Copy link
@goneri

goneri May 16, 2019

Author Contributor

I see, that's a good point.

@Akasurde Akasurde removed the needs_triage label May 7, 2019

@Akasurde Akasurde self-assigned this May 7, 2019

@goneri goneri closed this May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.