Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA1 to password_hash filter #56133

Open
wants to merge 21 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@dsroark
Copy link

commented May 6, 2019

SUMMARY

Add sha1 support for the password_hash jinja2 filter

Also replace most unit tests with integration tests for password_hash.

Fixes #26322

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

password_hash filter

@dsroark dsroark force-pushed the dsroark:issue_26322/sha1_bcrypt_filters branch from b14006c to 8dc3106 May 6, 2019

@dsroark dsroark changed the title WIP Issue 26322/sha1 bcrypt filters Fix Issue 26322/sha1 bcrypt filters and refactor tests May 7, 2019

@dsroark dsroark changed the title Fix Issue 26322/sha1 bcrypt filters and refactor tests Fix Issue 26322 and refactor tests May 7, 2019

@ansibot ansibot added core_review and removed WIP small_patch labels May 7, 2019

@ansibot ansibot added needs_revision and removed core_review labels May 7, 2019

droark

droark added some commits May 7, 2019

droark

@dsroark dsroark force-pushed the dsroark:issue_26322/sha1_bcrypt_filters branch from e950c93 to 90d9318 May 7, 2019

droark added some commits May 7, 2019

droark
droark
droark
fix for everyone else
- nested lists need to be inside lists for `with_flattened`
    + https://docs.ansible.com/ansible/2.4/playbooks_loops.html#id28
- set the no_crypts_passwords to an empty list instead of `omit`

@dsroark dsroark closed this May 7, 2019

@dsroark dsroark reopened this May 7, 2019

droark

@samdoran samdoran changed the title Fix Issue 26322 and refactor tests Add SHA1 to password_hash filter May 14, 2019

@samdoran samdoran removed the needs_triage label May 14, 2019

@ansibot ansibot added the stale_ci label May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.