Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] remove call to filecompare to fix issue with empty file exclusion fro… #56139

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@jm2242
Copy link

commented May 6, 2019

SUMMARY

Fixes #34569
Removes a call to filecmp that probably protected against adding the archive file to itself (but is unnecessary). This change fixes an issue where empty files were not being added to archives

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/files/archive.py

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

@samdoran samdoran added pycon_sprints and removed needs_triage labels May 6, 2019

@jm2242

This comment has been minimized.

Copy link
Author

commented May 8, 2019

I should get to this fix in the next few days!

@ansibot ansibot added the stale_ci label May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.