Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support data disk updated, and add write_accelerator_enabled option #56154

Open
wants to merge 7 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@yuwzho
Copy link
Contributor

commented May 7, 2019

SUMMARY

Fixes #49659

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_virtualmachine

ADDITIONAL INFORMATION

@yuwzho yuwzho changed the title Yuwzho datadisk Support data disk updated, and add write_accelerator_enabled option May 7, 2019

@ansibot

This comment has been minimized.

version_added: "2.4"
disk_size_gb:
description:
- The initial disk size in GB for blank data disks
- The initial disk size in GB for blank data disks.
- This value cannot be larger than 1023 GB.

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

it's so hard to understand logic, when os disk is manged disk, data disk is managed disk. etc.. can we add detail samples to demo how to do it? a special section for disk, it could be very helpful to users.

@@ -1472,17 +1474,19 @@ def exec_module(self, **kwargs):

return self.results

def get_vm(self):
def get_vm(self, fail_on_exception=True):

This comment has been minimized.

Copy link
@yungezz

yungezz May 7, 2019

Contributor

why need the fail_on_exception? seems all callers pass false

This comment has been minimized.

Copy link
@yuwzho

yuwzho May 8, 2019

Author Contributor

It used to pass True, here I just add one False caller...

@yuwzho yuwzho force-pushed the VSChina:yuwzho-datadisk branch from 2570bd9 to ffd83f7 May 15, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.