Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow python_requirements_facts to cope with packages with dashes #56166

Merged

Conversation

Projects
None yet
4 participants
@willthames
Copy link
Contributor

commented May 7, 2019

SUMMARY
python_requirements_facts:
  dependencies:
    - kubernetes-validate

should work as expected

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

python_requirements_facts

ADDITIONAL INFORMATION

2.8 backport candidate

Allow python_requirements_facts to cope with packages with dashes
```
python_requirements_facts:
  dependencies:
    - kubernetes-validate
```

should work as expected

@willthames willthames force-pushed the willthames:allow-python-requirements-with-dashes branch from e8bed6e to 5b3305c May 19, 2019

@willthames willthames force-pushed the willthames:allow-python-requirements-with-dashes branch from 7e10543 to 7e15930 May 21, 2019

@willthames willthames force-pushed the willthames:allow-python-requirements-with-dashes branch from 7e15930 to 757a736 May 21, 2019

@ansibot ansibot removed the needs_revision label May 21, 2019

@s-hertel s-hertel removed the needs_triage label May 21, 2019

@s-hertel s-hertel merged commit 8e1dd58 into ansible:devel May 21, 2019

1 check passed

Shippable Run 123710 status is SUCCESS.
Details
@s-hertel

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

+1 to backporting

willthames added a commit to willthames/ansible that referenced this pull request May 21, 2019

Allow python_requirements_facts to cope with packages with dashes (an…
…sible#56166)

* Allow python_requirements_facts to cope with packages with dashes

```
python_requirements_facts:
  dependencies:
    - kubernetes-validate
```

should work as expected

* Ensure tests run for python_requirements_facts

(cherry picked from commit 8e1dd58)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.