Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix netconf_config backup string issue #56188

Merged
merged 2 commits into from May 22, 2019

Conversation

Projects
None yet
5 participants
@ganeshrn
Copy link
Member

commented May 7, 2019

SUMMARY

Fixes #56022

  • Convert the ElementTree object to string
    before dumping the configuration in the file.
  • Fixed get_config to not require multiple parameters to just run a backup
  • Add Integration test for netconf_config

Cherry pick from 647ed20 and 9c5745a
Merged to devel
#56175
#56138

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

netconf_config

ADDITIONAL INFORMATION

Fixes Netconf_config single parameter bug (#56138)
* Fixes Netconf_config single parameter bug
Fixes 56022

fixed get_config to not require multiple parameters to just run a backup

* Add Integration test for netconf_config
Associated with #56022

tests backup through netconf only using one parameter.

* Added debug to the begin and end of file

* Fix formatting of save config.  #56022

* removed blank line at end: #56022

(cherry picked from commit 647ed20)
@ansibot

This comment has been minimized.

@lpenz

lpenz approved these changes May 8, 2019

Copy link

left a comment

LGTM, FWIW

@ansibot ansibot removed the needs_triage label May 8, 2019

@ansibot ansibot added the stale_ci label May 16, 2019

@abadger

This comment has been minimized.

Copy link
Member

commented May 21, 2019

This needs a changelog entry and can be merged once that is added.

Fix netconf_config backup string issue (#56175)
*  Convert the ElementTree object to string
   before dumping the configuration in file.

(cherry picked from commit 9c5745a)

@ganeshrn ganeshrn force-pushed the ganeshrn:backport/2.8/56175 branch from 84e80e0 to e0cb04b May 21, 2019

@ansibot ansibot added support:community and removed stale_ci labels May 21, 2019

@abadger abadger merged commit 3a3314e into ansible:stable-2.8 May 22, 2019

1 check passed

Shippable Run 123836 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented May 22, 2019

Merged for the 2.8.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.