Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delegate fails with ansible_host is None #56190

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
4 participants
@acmnu
Copy link

commented May 7, 2019

SUMMARY

Fixes #30630

There was no protective code for case when we have None value of ansible_host during delegation process.
Adds a check that value of address variables is not None during connection string calculation.

ISSUE TYPE
  • Bugfix Pull Request

COMPONENT NAME

play_context

ADDITIONAL INFORMATION

Fix #30630 delegate fails with ansible_host is None
There was no protective code for case when we have None
value of ansible_host during delegation process.
@acmnu

This comment has been minimized.

Copy link
Author

commented May 7, 2019

Got a test failed with some network trouble around http://. Hope it is not my bad.

@ansibot ansibot added the stale_ci label May 16, 2019

@jillr jillr removed the needs_triage label May 16, 2019

@bcoca bcoca changed the title Fix #30630 delegate fails with ansible_host is None Fix delegate fails with ansible_host is None May 16, 2019

@bcoca

This comment has been minimized.

Copy link
Member

commented May 16, 2019

#55219 would make this obsolete as play_context should not be used anymore, the true fix should happen in executor when connection is instanciated

@ansibot ansibot added core_review and removed needs_revision labels May 19, 2019

@acmnu

This comment has been minimized.

Copy link
Author

commented May 21, 2019

@bcoca, is #55219 expected to be available in next release? If so it's perfect! Otherwise I'd like to see that small patch in future bugfix release, just to stop me providing own Ansible version for our team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.