Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] R package installation via CRAN #56192

Open
wants to merge 5 commits into
base: devel
from

Conversation

Projects
None yet
3 participants
@chendaniely
Copy link

commented May 7, 2019

SUMMARY

Work from PyCon 2019 at the Ansible sprints with @samdoran.

This implements an Ansible module for installing R packages from CRAN.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

r_pkg_cran

ADDITIONAL INFORMATION
  • Fix integration tests
  • Make r package install/reinstall more robust
  • Make r package remove more robust
  • add news file fragment

Setup

docker run --name ansible_r --rm -it r-base bash

samdoran and others added some commits May 8, 2019

Sanity tests are failing due to missing __future__ import.
Co-Authored-By: chendaniely <chendaniely@users.noreply.github.com>
Merge branch 'r_pkg_cran' of github.com:chendaniely/ansible into r_pk…
…g_cran

* 'r_pkg_cran' of github.com:chendaniely/ansible:
  Sanity tests are failing due to missing __future__ import.
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@chendaniely this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/modules/packaging/language/r_pkg_cran.py:102:22: bad-whitespace No space allowed around keyword argument assignment         argument_spec = {                       ^
lib/ansible/modules/packaging/language/r_pkg_cran.py:131:0: trailing-whitespace Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

lib/ansible/modules/packaging/language/r_pkg_cran.py:72:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/packaging/language/r_pkg_cran.py:77:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/packaging/language/r_pkg_cran.py:84:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/packaging/language/r_pkg_cran.py:90:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/packaging/language/r_pkg_cran.py:100:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/packaging/language/r_pkg_cran.py:102:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/language/r_pkg_cran.py:102:24: E251 unexpected spaces around keyword / parameter equals
lib/ansible/modules/packaging/language/r_pkg_cran.py:108:13: E123 closing bracket does not match indentation of opening bracket's line
lib/ansible/modules/packaging/language/r_pkg_cran.py:121:48: E261 at least two spaces before inline comment
lib/ansible/modules/packaging/language/r_pkg_cran.py:125:49: E261 at least two spaces before inline comment
lib/ansible/modules/packaging/language/r_pkg_cran.py:131:1: W293 blank line contains whitespace
lib/ansible/modules/packaging/language/r_pkg_cran.py:133:5: E303 too many blank lines (2)

The test ansible-test sanity --test validate-modules [explain] failed with 22 errors:

lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E307 version_added should be '2.9'. Currently '2.4'
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E316 ANSIBLE_METADATA.metadata_version: not a valid value for dictionary value @ data['metadata_version']. Got '0.1'
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E319 RETURN.message.returned: required key not provided @ data['message']['returned']. Got None
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E319 RETURN.message.type: required key not provided @ data['message']['type']. Got None
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E319 RETURN.original_message.returned: required key not provided @ data['original_message']['returned']. Got None
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E322 Argument 'name' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E322 Argument 'state' is listed in the argument_spec, but not documented in the module documentation
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'ad_user' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'adfs_authority_url' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'api_profile' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'auth_source' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'cert_validation_mode' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'client_id' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'cloud_environment' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'password' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'pkg_name' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'profile' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'secret' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'subscription_id' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E323 Argument 'tenant' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E324 Argument 'state' in argument_spec defines default as ('present') but documentation defines default as (None)
lib/ansible/modules/packaging/language/r_pkg_cran.py:0:0: E326 Argument 'state' in argument_spec defines choices as (['absent', 'present']) but documentation defines choices as ([])

click here for bot help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.