Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement feature request to support UseDefaultCredentials (54658) #56196

Open
wants to merge 3 commits into
base: devel
from

Conversation

Projects
None yet
4 participants
@ShachafGoldstein
Copy link
Contributor

commented May 7, 2019

SUMMARY

Implement feature request to support UseDefaultCredentials as mentioned in issue #54658

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_uri

ADDITIONAL INFORMATION
@ansibot

This comment has been minimized.

@jhawkesworth

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

This looks like a nice addition.
Consider whether this should be added to win_get_url as wel (in a separate PR). If so it should have the same parameter name.
Having read https://docs.microsoft.com/en-us/dotnet/api/system.net.credentialcache.defaultcredentials?view=netframework-4.8#remarks I am not sure what the default credential would be as I think the login type will not be interactive unless you use 'become'. This may not be an issue as I don't fully understand windows login authentication mechanism, but I thought it was worth asking.

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

This looks like a nice addition.
Consider whether this should be added to win_get_url as wel (in a separate PR). If so it should have the same parameter name.
Having read https://docs.microsoft.com/en-us/dotnet/api/system.net.credentialcache.defaultcredentials?view=netframework-4.8#remarks I am not sure what the default credential would be as I think the login type will not be interactive unless you use 'become'. This may not be an issue as I don't fully understand windows login authentication mechanism, but I thought it was worth asking.

Since there is the issue of double hop in Kerberos you'll have to use become, for NTLM or CREDSSP (when configured correctly) should work.

Maybe we should consider merging the two singe httpwebrequest is derived from web request
(win_uri)

@jhawkesworth

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Please consider adding an example that uses 'become' to demonstrate usage, if 'become' is actually required.

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

Should test KERB, NTLM, CREDSSP and update docs accordingly

EDIT:

  • NTLM works
  • KERB and CREDSSP ill take some more time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.