Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meraki_ssid - Improve change reporting #56201

Open
wants to merge 2 commits into
base: devel
from

Conversation

Projects
None yet
2 participants
@kbreit
Copy link
Contributor

commented May 8, 2019

SUMMARY

Previous to this PR, there were some situations where an action would show as changed even when it wasn't. This PR fixes many of those and improves integration test code coverage to test for change status.

The new is_update_required() algorithm in #48394 will further improve the status checks.

  • Documentation is more clear about dependencies
  • Not all change reports are accurate without new algorithm
  • Improved integration tests

Fixes #51561

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

meraki_ssid

ADDITIONAL INFORMATION
TASK [meraki_ssid : Set VLAN arg spec] *****************************************
 [WARNING]: Bridge mode

changed: [localhost]

TASK [meraki_ssid : assert] ****************************************************
ok: [localhost] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [meraki_ssid : Set VLAN arg spec] *****************************************
ok: [localhost]

TASK [meraki_ssid : assert] ****************************************************
ok: [localhost] => {
    "changed": false,
    "msg": "All assertions passed"
}

Improve change reporting for meraki_ssid
- Documentation is more clear about dependencies
- Not all change reports are accurate without new algorithm
- Improved integration tests
@ansibot

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.